Better patch for #37 (missing sidebar on direct comic pages)#39
Better patch for #37 (missing sidebar on direct comic pages)#39ilyvion merged 4 commits intoQuestionable-Content-Extensions:developfrom
Conversation
More idiomatic fix for Issue Questionable-Content-Extensions#37. It uses jQuery within the proper file, just before adding the sidebar base. It also directly tests the DOM to see if the "small-2" column is missing, rather than just guessing using the URL.
No new features, just a bug fix , so only upped minor version number.
Minor version upped because bugfix--no new features
|
I tried finding a quick solution, but none came to mind... |
|
I'll just approve it and publish it anyway, it's better than having nothing at all, for sure. |
|
Oh, I forgot about that. Someone in one of the subreddits already created a Userscript that fixed that, and I've been using that this whole time, with some of my own tweaks. The trick it uses is to move those links below the sidebar. (Though, if you wanted, you could move them anywhere.) Here's the code from that extension: |
|
And here's the same code in jQuery: Though, personally, I think moving it to where it is on the front page would make more sense. I'll look into that. |
|
I also note that, if you don't have adblock enabled, the text does actually appear at the bottom of the page, so moving it down there is entirely consistent with his intention. |

This patch is more idiomatic than #38, placing the change in the proper file and location (with comment), and using jQuery rather than raw JavaScript. It tests the DOM to see if the required column element (class ".small-2") is present and creates it if not, rather than testing the URL.
It also includes a version update in both the package and package-lock files, as well as an entry in the change-log, making for a more complete fix.
I realize you're busy, so I wanted to make things as simple as possible for you to help the fix get out quickly. Cheers!